lib/pull: Avoid journaling 404s for optional content
authorColin Walters <walters@verbum.org>
Wed, 5 Jul 2017 20:41:38 +0000 (16:41 -0400)
committerAtomic Bot <atomic-devel@projectatomic.io>
Thu, 13 Jul 2017 21:41:00 +0000 (21:41 +0000)
commit620a90ebfaf98f779b77cd8f97da1d06e146b832
tree79fedc7f52da2f0505016f8031bb995951a79d2f
parent82024f161b280b4ef70880ddd5bc83ad812e6f0a
lib/pull: Avoid journaling 404s for optional content

Currently in Fedora we don't sign summaries, and every use of
`rpm-ostree` would emit to the journal an error when we failed
to fetch it.

Fix this by having `OSTREE_FETCHER_REQUEST_OPTIONAL_CONTENT` tell the fetcher
not to journal 404 errors. While fixing this, we had a mix of two booleans vs
the flags; fix things so we consistently use the flags in the fetcher and pull
code.

Closes: #1004
Approved by: mbarnes
src/libostree/ostree-fetcher-curl.c
src/libostree/ostree-fetcher-soup.c
src/libostree/ostree-fetcher-util.c
src/libostree/ostree-fetcher-util.h
src/libostree/ostree-fetcher.h
src/libostree/ostree-metalink.c
src/libostree/ostree-repo-pull.c